> On June 10, 2014, 10:46 p.m., Sravya Tirukkovalur wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java, > > lines 461-463 > > <https://reviews.apache.org/r/22240/diff/7/?file=606349#file606349line461> > > > > This can just be: > > > > Table currTbl = Table.ALL; > > if ((DEFAULT_DATABASE_NAME.equalsIgnoreCase(currDB.getName()) && > > "false".equalsIgnoreCase(authzConf. > > > > get(HiveAuthzConf.AuthzConfVars.AUTHZ_RESTRICT_DEFAULT_DB.getVar(), > > "false"))) > > ) { > > currDB = Database.ALL; > > currTbl = Table.SOME; > > }
this doesnt look like has been resolved? - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22240/#review45306 ----------------------------------------------------------- On June 10, 2014, 10:52 p.m., Arun Suresh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22240/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 10:52 p.m.) > > > Review request for sentry, Jarek Cecho, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Couple of Test case fixes to get the filter push down patch to work. > > NOTE : I have placed some TODOs where I make a few assumptions.. kindly review > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 812f310 > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/AccessConstants.java > 9f5035e > > sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/Table.java > 62a0a81 > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBModelAuthorizables.java > f4b32e1 > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPrivilege.java > cab1234 > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > 3a993b0 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java > 326b91d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 5560729 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > a1cf24a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java > 2198c05 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSandboxOps.java > 5eef792 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegeAtTransform.java > 732632b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java > 1e93ec6 > > Diff: https://reviews.apache.org/r/22240/diff/ > > > Testing > ------- > > > Thanks, > > Arun Suresh > >
