> On June 12, 2014, 10:40 p.m., Prasad Mujumdar wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java, > > line 264 > > <https://reviews.apache.org/r/22534/diff/1/?file=608322#file608322line264> > > > > Nit: AccessConstants.ALL_ROLE ? > > Sravya Tirukkovalur wrote: > AccessConstants.ALL is actually * and we do not support "grant * on.." in > hive, we only support "grant all on .." > > Prasad Mujumdar wrote: > right, I was referring to AccessConstants.ALL_ROLE which is 'ALL'
Ah, my bad I over looked it :-). But for this case, I think lets just keep it "ALL" itself, as using roles constant to compare actions can get confusing when reading code. > On June 12, 2014, 10:40 p.m., Prasad Mujumdar wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java, > > line 295 > > <https://reviews.apache.org/r/22534/diff/1/?file=608322#file608322line295> > > > > Should be save and restore the current database ? This might be a > > problem based on the order of objects in the policy files. > > > > Hive sets a config property, hive.current.db to the current database > > name. That could be used here. > > > > > > Sravya Tirukkovalur wrote: > Ah, thats true. This has not caused any test failures mostly because this > granting privilege is done at the test beginning mostly. Sure, lets do that > as a follow on jira? > > Prasad Mujumdar wrote: > sure. Please feel free to log a followup ticket. Thanks! Filed https://issues.apache.org/jira/browse/SENTRY-298, thanks! - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22534/#review45543 ----------------------------------------------------------- On June 12, 2014, 9:56 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22534/ > ----------------------------------------------------------- > > (Updated June 12, 2014, 9:56 p.m.) > > > Review request for sentry, Arun Suresh and Prasad Mujumdar. > > > Bugs: sentry-293 > https://issues.apache.org/jira/browse/sentry-293 > > > Repository: sentry > > > Description > ------- > > Refactored the db provider test code to be able to use external secure Hive > and Sentry. > > Also: > - Added test cases descriptions in TestDatabaseProvider (and a test case) > - Refactored TestDatabaseProvider and TestDbEndtoEnd to use static test > configuration. > - removed core-site as it is interfering with classpath on real deployments. > > > Diffs > ----- > > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java > ceeb6537f84c12c1ff8615d891539906690beb25 > sentry-tests/sentry-tests-hive/pom.xml > cd95252cad0fa860b0c1c7a5e730b6f62bae3866 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/PolicyProviderForTest.java > 47ce66d1f285e31304637e12d0ab50a7b72e1809 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > 44f41be20888963973317dbba58c1272cfa583c3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbCrossDbOps.java > 6411e2b8451f48e553bd7c06fe3f113da7625c1f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java > 634dd526dd2804849c2311d32bc23196f7f4e923 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbExportImportPrivileges.java > 78677ba4d8b3d07811580644f9a2a5d47cfc2b02 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMetadataObjectRetrieval.java > 2701e558ed59f98ff9f74b3887f43ccce0d9843c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMetadataPermissions.java > e311e513210235df485d7cc0790798cc0e5937f0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMovingToProduction.java > 4b44e6333809e9999bacfd4f84e6c628b6e4dff6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeAtTransform.java > 2cbf0a776b617a7dd38f1478a550c1e0d87d5d7b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtDatabaseScope.java > 7ea8166efcc6c9aaa666e439eb62030b064ffc16 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtFunctionScope.java > e12b072a354e28b89c87b978262603b578367c31 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java > db17012d97b54d2217ad874e528ea978fb0eec2d > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbRuntimeMetadataRetrieval.java > 302492a5de5ed340bccbe0a6c91643851d21a1f2 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSandboxOps.java > f8227852f2f098437696078257e9f4443f1ef2d0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUriPermissions.java > f52fb67b80bacec8575c48c8def9ab5137ede43e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbUserManagement.java > e24137dc96aba98e5e69e3cb704d118e6a166239 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 952b02169b5234d8f395ebf4206bf8b2e550521e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestConfigTool.java > bb7bec213daf4caff6bc62bdcf560a8c458fb226 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > 84e3b19ab0815f9adcda9ba08c9c5894a2ed7e89 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java > 6c87c6558f522cd0ac7c384b138464add7046d1a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java > 411a8e9bbe62edc758caf9cef467564a7068b43e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java > b10c0c29661d613058fb0b8743fb35a032560fea > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataPermissions.java > e0642e7b85c2ece6c01e710158319c4b8f1f0e69 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMovingToProduction.java > 0889615a30742ac91cfd94cf073c991119446533 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java > f782613b1ce4a744e6a9f29c94555b3eb34394a3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDatabasePolicyFile.java > 85c83af23452c61a0d6779f693fb8f44f271ad6c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegeAtTransform.java > bc20213c4e142be887a1db733e69a67b6e3e332c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java > 029d8d5c57956822ab655c7d9ad406b97ee3bc0b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java > 2c9924b86c34bcb50f641d4a0e870bca63d67e92 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java > 6b493c47cbd88d3a4bb1a1ee483cf60ec3f5ab7e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java > ddb1c8bac71740ad89f80a1a4a20ac62f6d059c5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java > a71856fc5b89f7428155b2935f30fca902ffac7a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java > a12c9c5a2b286465dca420691cc0bf9c0ae4c4bd > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java > a985e64d95acdae7fc5586410103d5642e72ebf0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/ClusterDFS.java > a16bb380df4b6b349069ba02d815e5d869e4dd97 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > c0dc939bc76d96a43fe403803fc6e6e17c983cf3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/UnmanagedHiveServer.java > 42a274fc41e66aceaf713906f05e7f7fcdf8a784 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > fe10f5d445f778dd3d75587c9204abc36188e93e > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetaStoreWithPigHCat.java > 46feace7153a69701fdaacd80d3d7b97475f7ef6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > 1aed84d82436fec6bb8d8c1b8bb9ba5008c3c947 > sentry-tests/sentry-tests-hive/src/test/resources/core-site.xml > 676dc12b70021162f9df138cd4c73b1bf0ec8369 > > Diff: https://reviews.apache.org/r/22534/diff/ > > > Testing > ------- > > Ran tests on a real deployment with -Pcluster-hadoop-provider-db > > > Thanks, > > Sravya Tirukkovalur > >
