-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22578/
-----------------------------------------------------------
(Updated June 13, 2014, 6:39 p.m.)
Review request for sentry and Prasad Mujumdar.
Changes
-------
Updated some comments
Bugs: sentry-300
https://issues.apache.org/jira/browse/sentry-300
Repository: sentry
Description
-------
Refactored the code a little bit so that we have following checks for the
following paths:
If request coming from HiveServer2, we make sure:
hive.server2.authentication !=none
hive.server2.enable.doAs = false
If request coming from HiveMetastore, we make sure:
hive.metastore.sasl.enabled = true
hive.metastore.execute.setugi = true
Also now, invalid configurations throw InvalidConfigurationException, rather
than using a dummy provider.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java
39f5384a059d5c2df1cbda986f9e2af727421409
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java
30c348845150b87cdda5f6266d7d804cc20fc39e
sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java
e6d790a4d09f3f5e7b019dfcbbf50d5a65ddba4d
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java
4985912fbf16d362107d3168d115ff92282589f3
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestServerConfiguration.java
c05bb4fa69591c4f8ce6225939fab34db5b217e1
Diff: https://reviews.apache.org/r/22578/diff/
Testing
-------
Added new test cases.
Thanks,
Sravya Tirukkovalur
