-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22494/
-----------------------------------------------------------

(Updated June 18, 2014, 12:32 a.m.)


Review request for sentry, Jarek Cecho, Prasad Mujumdar, and Sravya 
Tirukkovalur.


Changes
-------

Updating patch with minor change :
- When granting INSERT/SELECT on table, if ALL already exists, don't do 
anything (to prevent making a really annoying check in the revoke path)
 


Bugs: SENTRY-281
    https://issues.apache.org/jira/browse/SENTRY-281


Repository: sentry


Description
-------

Fix for SENTRY-281 :

A revoke on a parent privilege should trickle to the child.
For eg :

1) GRANT SELECT on DATABASE db1 to ROLE role1;
2) REVOKE ALL on SERVER server1 from ROLE role1;

Should result in zero privileges for role1


Diffs (updated)
-----

  
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
 91669d6 
  
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
 35ba83a 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java
 6187692 
  
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java
 46d9332 

Diff: https://reviews.apache.org/r/22494/diff/


Testing
-------

Tested on sentry-hive-tests


Thanks,

Arun Suresh

Reply via email to