----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22854/#review46364 -----------------------------------------------------------
Ship it! Ship It! - Jarek Cecho On June 21, 2014, 5:21 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22854/ > ----------------------------------------------------------- > > (Updated June 21, 2014, 5:21 p.m.) > > > Review request for sentry, Jarek Cecho and Sravya Tirukkovalur. > > > Bugs: SENTRY-244 > https://issues.apache.org/jira/browse/SENTRY-244 > > > Repository: sentry > > > Description > ------- > > Sentry config class extends hadoop Configuration class. The deprecated > properties are handled in the 'get(property)' method. The problem is that the > failure hook is loaded using get(property, default) method which is not > overloaded. Hence we don't handle the deprecated property in that case. > The patch adds that missing wrapper in Sentry config class > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > c126743 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzConf.java > 1942e03 > > Diff: https://reviews.apache.org/r/22854/diff/ > > > Testing > ------- > > Updated the test case to verify new API. > > > Thanks, > > Prasad Mujumdar > >
