----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22821/#review46440 -----------------------------------------------------------
Ship it! Ship It! - Sravya Tirukkovalur On June 23, 2014, 6:58 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22821/ > ----------------------------------------------------------- > > (Updated June 23, 2014, 6:58 a.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-309 > https://issues.apache.org/jira/browse/SENTRY-309 > > > Repository: sentry > > > Description > ------- > > The Alter and add partition operations are using the URI passed directly by > Hive. We need to convert those to fully qualified format before passing to > Sentry auth check. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 9da020c > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java > c87e258 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > e32aae8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > fd969a6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/DFSFactory.java > c897b49 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/fs/MiniDFS.java > a96a1ce > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 0165806 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/InternalMetastoreServer.java > b1f404f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 7084400 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/SentryPolicyProviderForDb.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetaStoreWithPigHCat.java > 8a2bf59 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > c672ef0 > > sentry-tests/sentry-tests-hive/src/test/resources/core-site-for-sentry-test.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/22821/diff/ > > > Testing > ------- > > > Thanks, > > Prasad Mujumdar > >
