----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23004/#review46804 -----------------------------------------------------------
Ship it! LGTM. Thanks Prasad! - Sravya Tirukkovalur On June 26, 2014, 8:23 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23004/ > ----------------------------------------------------------- > > (Updated June 26, 2014, 8:23 a.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-314 > https://issues.apache.org/jira/browse/SENTRY-314 > > > Repository: sentry > > > Description > ------- > > - ad null check for storage descriptor > - Perform the check for metastore authorization at the very beginning to > avoid unnecessary code and potential bugs > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java > 5d7d9a4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 549a0fa > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > 52a2b1e > > Diff: https://reviews.apache.org/r/23004/diff/ > > > Testing > ------- > > Updated test cases to use null storage descriptor > Added testcases for Hive statement that submit null storage descriptor. > > > Thanks, > > Prasad Mujumdar > >
