----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23721/#review48301 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java <https://reviews.apache.org/r/23721/#comment84713> Nit: reset table type which is on by default sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java <https://reviews.apache.org/r/23721/#comment84715> Not sure what we are doing here by setting authorizer to null? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java <https://reviews.apache.org/r/23721/#comment84716> Can you please file a follow on to track this Prasad? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingSessionHook.java <https://reviews.apache.org/r/23721/#comment84734> Wonder, what was this hive_extended_entity_capture being used for earlier? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingSessionHook.java <https://reviews.apache.org/r/23721/#comment84735> Is this required? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java <https://reviews.apache.org/r/23721/#comment84790> Wonder what is the semantics of this command? Can we file a follow on jira as this might lead to unexpected output as we are not explicitly handling this case and not throwing not supported exception? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java <https://reviews.apache.org/r/23721/#comment84792> Do we need this output privilege for the alter table add partition? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java <https://reviews.apache.org/r/23721/#comment84797> Is this a hive 0.13 bug? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java <https://reviews.apache.org/r/23721/#comment84793> Nit: Can we remove these commented out lines? Thanks for the patch Prasad! It mostly looks good to me. Some minor issues below. - Sravya Tirukkovalur On July 21, 2014, 10:50 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23721/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 10:50 p.m.) > > > Review request for sentry, Brock Noland and Sravya Tirukkovalur. > > > Bugs: SENTRY-326 > https://issues.apache.org/jira/browse/SENTRY-326 > > > Repository: sentry > > > Description > ------- > > - Removed the resultset filter hook > - Added a metastore client wrapper that filter out the metadata > - Additional 0.13 compatibility changes > - Includes SENTRY-324 and SENTRY-325 changes > > > Diffs > ----- > > pom.xml 05943c6 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java > 26eea91 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > 27a10ee > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryHivePrivilegeObjectDesc.java > 0447e26 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 44c0d20 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingSessionHook.java > 1bd0bec > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java > 991d734 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzBinding.java > 5a8ca6f > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > 4b2723a > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java > 5c43095 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryHiveMetaStoreClient.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java > 23e91f0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java > dac0b92 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestServerConfiguration.java > 436e842 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 44331f6 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/InternalHiveServer.java > 02d8024 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > b376c37 > > Diff: https://reviews.apache.org/r/23721/diff/ > > > Testing > ------- > > Full regression run passes with the patch > > > Thanks, > > Prasad Mujumdar > >
