----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23727/#review48321 -----------------------------------------------------------
Ship it! Looks fine to me. A couple of minor suggestions below. Feel free to skip those. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java <https://reviews.apache.org/r/23727/#comment84809> Nit: I guess the comment is bit misleading. We seems to be using File.milliseconds. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java <https://reviews.apache.org/r/23727/#comment84810> Nit: white space - Prasad Mujumdar On July 21, 2014, 7:21 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23727/ > ----------------------------------------------------------- > > (Updated July 21, 2014, 7:21 a.m.) > > > Review request for sentry and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > The patch is based on the JIRA: Sentry-346: Create new FileAppender used in > log4j to keep all the logs. > > https://issues.apache.org/jira/browse/SENTRY-346 > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/log/appender/RollingFileWithoutDeleteAppender.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/log/appender/TestRollingFileWithoutDeleteAppender.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/23727/diff/ > > > Testing > ------- > > The unit test is included in the patch. > > > Thanks, > > Colin Ma > >
