----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23600/ -----------------------------------------------------------
(Updated July 24, 2014, 9:41 p.m.) Review request for sentry, Jarek Cecho, Prasad Mujumdar, and Sravya Tirukkovalur. Changes ------- @Brock, Thanks for the catch.. yep oracle does screw up the empty strings. I have modified the patch to convert empty/null strings to "__NULL__". Ideally, I would have liked JDO to handle these Db disparities.. Repository: sentry Description ------- SENTRY-339 : Remove the need to construct a privilegeName to check for uniqueness. - Remove the PrivilegeName column - Remove the constructPrivilegeName() method - Updated the sql scripts Diffs (updated) ----- sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9e8ac4c sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java f8491db sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 945227e sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff8acdc sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 3bb7285 sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql f2a62d2 sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql f2a62d2 sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql 70f4dbb sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql 363590e sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql 5dfae03 sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift fdc7b9c sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 7637376 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerWithoutKerberos.java 79579c6 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java a4ae291 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java 948b0c4 Diff: https://reviews.apache.org/r/23600/diff/ Testing ------- Ran all e2e tests and unit tests. Thanks, Arun Suresh
