----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23794/ -----------------------------------------------------------
(Updated July 28, 2014, 8:02 a.m.) Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur. Changes ------- rewrite grant check with grant option. 1. change grantorPricipal from roleName to userName userName->groups via groupMapping, groups->roles, roles->privileges 2. Using LocalGroupMapping to test. Repository: sentry Description ------- A role has a privilege with grant option, he can grant/revoke the privilege or child privilege to/from other roles. A role in adminGroups, he can grant privilege to any roles. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryNoGrantOpitonException.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff8acdc sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 3bb7285 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 7637376 Diff: https://reviews.apache.org/r/23794/diff/ Testing ------- The unit test is included in the patch. Thanks, Xiaomeng Huang
