> On July 28, 2014, 10:37 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift, > > line 49 > > <https://reviews.apache.org/r/23788/diff/1-2/?file=638814#file638814line49> > > > > I am not a thrift expert, but looks like thrift does support bool: > > http://wiki.apache.org/thrift/Tutorial > > > > Also, can you update the patch on the jira as well?
Discussed this on a different jira, so we can close this issue. - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23788/#review48922 ----------------------------------------------------------- On July 28, 2014, 10:06 a.m., Sun Dapeng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23788/ > ----------------------------------------------------------- > > (Updated July 28, 2014, 10:06 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > TSentryGrantOption.java and TSentryPrivilege.java are auto-generate by thrift. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java > 9e8ac4c > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > fdc7b9c > > Diff: https://reviews.apache.org/r/23788/diff/ > > > Testing > ------- > > > Thanks, > > Sun Dapeng > >
