----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24151/ -----------------------------------------------------------
(Updated Aug. 4, 2014, 2:33 p.m.) Review request for sentry, Arun Suresh, Jarek Cecho, Prasad Mujumdar, and Sravya Tirukkovalur. Changes ------- Updated the patch accroding Sravya's comments. Repository: sentry Description ------- This review request contains all 8 subtasks(need apply the patch of SENTRY-339 first) SENTRY-340 Database implement for "with grant option" SENTRY-341 Extend Thrift API for SentryStore to support "with grant option" SENTRY-343 Privileges query from database support for "With Grant Option" SENTRY-370 Judgement of MSentryPrivilege implies child privileges SENTRY-342 Grant check with grant option SENTRY-345 Revoke check with grant option SENTRY-349 Extend Hive Hook with Grant Option SENTRY-377 Add Hive e2e test for grantOption Diffs (updated) ----- sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java 26eea91 sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java 27a10ee sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryHiveAuthorizationTaskFactoryImpl.java 991d734 sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryHiveAuthorizationTaskFactory.java ac0d170 sentry-core/sentry-core-common/pom.xml d1785b8 sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java 962179f sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBWildcardPrivilege.java 896283c sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryGrantOption.java PRE-CREATION sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryPrivilege.java 9e8ac4c sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SentryGrantDeniedException.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java f8491db sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo 945227e sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff8acdc sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java 5fd4f8f sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java 3bb7285 sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql f2a62d2 sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql f2a62d2 sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql 70f4dbb sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql 363590e sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql 5dfae03 sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift fdc7b9c sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryPrivilege.java PRE-CREATION sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 7637376 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java a4ae291 sentry-provider/sentry-provider-file/pom.xml b834c8e sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java PRE-CREATION Diff: https://reviews.apache.org/r/24151/diff/ Testing ------- Unit tests in local Thanks, Sun Dapeng
