The tag "(release 1.4.0-rc0/SHA: 5e6e34202b26d7d5bc1a41e3dd4ad0 cacd123e3f):" seems incorrect. I don't see any tag "release 1.4.0-rc0" and the SHA doesn't match the tag SHA 73dcf89677b2764d6ad842cca85798d56c4be985. It seems you are using the sha of the archive rather than the tag, which is inconsistent at least with how we did the 1.3.0 release (I didn't check further back than that).
Besides that, everything looks good: - The signature checks out - The checksums are correct - The archive matches the source tree I don't really whether the above should require a new rc or not. I'd argue not because you linked correctly to the tag and one can find the correct SHA from the link. Therefore, I'm +1. Greg On Mon, Aug 11, 2014 at 10:40 AM, Vamsee Yarlagadda <[email protected]> wrote: > +1 > Compiled all the modules and ran solr specific tests, and checked license. > > > On Mon, Aug 11, 2014 at 10:16 AM, Sravya Tirukkovalur <[email protected] > > > wrote: > > > +1, LGTM > > Checked hashes, signatures, licenses etc. Compiles and builds fine. > > > > Regards, > > > > > > On Sat, Aug 9, 2014 at 6:36 PM, Brock Noland <[email protected]> wrote: > > > > > +1 > > > > > > ran tests, checked sums, license, etc. > > > > > > On Fri, Aug 8, 2014 at 11:19 AM, Arun Suresh <[email protected]> > > > wrote: > > > > +1 > > > > > > > > * Ran tests, things look fine > > > > > > > > > > > > On Fri, Aug 8, 2014 at 10:55 AM, Jarek Jarcec Cecho < > [email protected] > > > > > > > wrote: > > > > > > > >> +1 > > > >> > > > >> * Checked checksums and signature > > > >> * Verified top level files (LICENSE, ...) > > > >> * Run tests, seens some flakiness but nothing concerning > > > >> > > > >> Jarcec > > > >> > > > >> On Aug 6, 2014, at 1:43 PM, Tuong Tr. <[email protected]> > > wrote: > > > >> > > > >> > Sentry Community, > > > >> > > > > >> > This is the incubator release of Apache > > > >> > Sentry, version 1.4.0-incubating. > > > >> > The list of fixed issues, added features and improvements can be > > found > > > >> here: > > > >> > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-sentry.git;a=blob;f=CHANGELOG.txt;h=962ac73d6b091093ac9ee72b675a3de1b241d242;hb=branch-1.4.0 > > > >> > > > > >> > Source files : http://people.apache.org/~sravya/sentry-1.4.0-rc0/ > > > >> > > > > >> > > > > >> > > > > >> > Tag to be voted on is (release 1.4.0-rc0/SHA: > > > >> 5e6e34202b26d7d5bc1a41e3dd4ad0cacd123e3f): > > > >> > > > > > > https://git-wip-us.apache.org/repos/asf/incubator-sentry/repo?p=incubator-sentry.git;a=log;h=refs/tags/release-1.4.0 > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > > > > >> > Sentry's KEYS containing the PGP key we used to sign the release: > > > >> > http://www.apache.org/dist/incubator/sentry/KEYS > > > >> > > > > >> > Note that this is a source only release and we are voting on the > > > source > > > >> > (release 1.4.0-rc0/SHA: 5e6e34202b26d7d5bc1a41e3dd4ad0cacd123e3f). > > > >> > > > > >> > Vote will be open for 72 hours. > > > >> > > > > >> > [ ] +1 approve > > > >> > [ ] +0 no opinion > > > >> > [ ] -1 disapprove (and reason why) > > > >> > > > > >> > > > > >> > Thank you for your prompt votes.. > > > >> > > > > >> > Thanks to Sravya for all her help and guidance... > > > >> > > > > >> > > > > >> > Respectfully, > > > >> > > > > >> > Sentry 1.4.0 Release Manager (Tuong Truong) > > > >> > > > >> > > > > > > > > > > > -- > > Sravya Tirukkovalur > > >
