----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24945/ -----------------------------------------------------------
(Updated Aug. 21, 2014, 9:08 p.m.) Review request for sentry and Prasad Mujumdar. Changes ------- Thanks for the review Prasad, updated the patch based on your comment. Repository: sentry Description ------- Trivial fix to make all tests use predefined databases, to be able to drop them in @After. We do not want to drop the databases which do not belong to the test, especially in the real cluster runs. Diffs (updated) ----- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/AbstractTestWithDbProvider.java 5d7428a8a953f5a83693d1c89d40177e01c3f0dc sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java e2c39eaf7a54b7d7e8ca87c2ecbade11202bc4e9 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbEndToEnd.java 9e97b2111de7b82ad393b084ec2927752a9996cc sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java a885b8f12c19dd4b0df5ab0f5036368c71b5f98a sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 31d8172e4fd6687d15140a4f15d37e7dda5ba3dc sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java 447f4d9df039e852c3a3071c6548a256c7d59fbd sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java 0901b679eaca0849ba2382a864f8182daeb942ca sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataPermissions.java 1e217a31323ad082bd703f6755428b9b9d7c038a sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMovingToProduction.java 67cbd32641d39742886a5fd0375795be4197f12f sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java 41bd083777340a091b923702c948d8787f80466b sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java 10f5dc818349ee71595add4d23f5e19db974be1e sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDatabasePolicyFile.java b31446c19faf5e36050833ae7153c0a8f25e11df sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegeAtTransform.java d115cad5bf8860e0c836bc1d91e7e212b28efa2b sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java a0669cd92787bb598f17b10130d21077509497ab sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java 1e1978d1b6b8cd413302be37dadf7de665ef998c sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java 2fece0aa736ebe921970155d6b78634cfca7411f sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestRuntimeMetadataRetrieval.java e932e8f46be0208074ac651808def748df046d21 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestSandboxOps.java 8710cd3b935707260423a9984e2548ea2acfe52e sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 8a857e0fe4100b05d0da8c0f6072ad7bb8cec5e1 Diff: https://reviews.apache.org/r/24945/diff/ Testing ------- Ran all tests in sentry-hive Thanks, Sravya Tirukkovalur
