Thanks for taking initiative to drive this! Sounds good to me, though it's always possible to see unrelated failures due to machine issues, possible flaky tests. Perhaps we should allow a followup re-validation of failed tests by the fixer.
thanks Prasad On Tue, Aug 26, 2014 at 5:08 PM, Sravya Tirukkovalur <[email protected]> wrote: > Hi Sentry contributors, > > We have had our pre commit build pretty unstable for a while. After some > test fixes and improved bigtop slaves health, it is back to being healthy > now. > http://bigtop01.cloudera.org:8080/job/PreCommit-SENTRY-Build/ (All red > ones > are actual patch related test failures). > > Lets take this opportunity to make "all tests passing" on precommit build a > requirement for every patch. Of course, we will file jiras for un related > flaky tests and prioritize them to unblock the commits if need be. Any > thoughts? > > Thanks! > -- > Sravya Tirukkovalur >
