----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25082/#review51802 -----------------------------------------------------------
Ship it! LGTM - Prasad Mujumdar On Aug. 27, 2014, 6:50 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25082/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 6:50 p.m.) > > > Review request for sentry, Prasad Mujumdar and Tuong Trg. > > > Repository: sentry > > > Description > ------- > > SENTRY-411: Alter table set location does not strictly check for URI > privileges > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > 761082aaa7d4c36ebc09dc45dceebcb5286036a6 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java > 2ff8a08e91e6836972af0ef55d8781666128ebbf > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 3a7aa41434f57290770d2cec0d0489bae11e713b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java > fddb343ce9d14e2a8276a2144da4439b9ec242dd > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtDatabaseScope.java > 653b6fb40f338cc7049db0c738fb20bf643438cc > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java > c55278c0795ce51a8ef502d09a923331d1fe6beb > > Diff: https://reviews.apache.org/r/25082/diff/ > > > Testing > ------- > > Added new tests and fixed existing tests. > > > Thanks, > > Sravya Tirukkovalur > >
