-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25197/
-----------------------------------------------------------
(Updated Aug. 30, 2014, 12:46 a.m.)
Review request for sentry, Lenni Kuff and Prasad Mujumdar.
Changes
-------
ALTER_METADATA(HiveParser.TOK_PRIV_ALTER_METADATA, "Alter") in
PrivilegeType.java causes privilegeType.name() to be returned as
ALTER_META_DATA rather than "Alter", hence changing it to toString().
Bugs: sentry-331
https://issues.apache.org/jira/browse/sentry-331
Repository: sentry
Description
-------
Adding more granular privileges to the DBModel: Create, Drop, Alter, Index and
Lock.
Following broad rules apply:
- Creating a data object requires "create" privilege on the parent. That is,
create table requires create on db, create db requires create on server.
- Dropping a data object requires "drop" privilege on that object.
- All alter commands require "alter" privilege on that table with the following
exceptions:
-- Alter table drop also requires "drop" privilege on the table in addition to
"alter".
-- Alter table index rebuild only requires "index" privilege on the table
-- Alter table rename also requires "create" on db.
- Locking table requires "lock" on table.
This patch also fixes SENTRY-413 and SENTRY-414
Note: I put comment "//TODO: Make sure" in the places where a second opinion
will help to make sure we are enforcing the right privileges for those commands.
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/SentryHiveConstants.java
49922f9f764579453a23bc4ccea9ce09f5fbcebd
sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java
0b268068b71b3602b95ddde9c87b21f4bfdc5754
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java
2df741cab38aa6e7677d13da9677f8ea398149c6
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java
9498a2806a997c441bf86bcc4b0f229d46cb1777
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/AccessConstants.java
4e89f68dccbf92ab26d4150e929d363f2f098f27
sentry-core/sentry-core-model-db/src/main/java/org/apache/sentry/core/model/db/DBModelAction.java
a4f3a87862312794fe724f1cffc8926de8b3deba
sentry-policy/sentry-policy-db/src/test/java/org/apache/sentry/policy/db/TestDBWildcardPrivilege.java
f4862e0a072c43b46f5470b988c8bc9419eb1fe1
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java
30cbb0db13d190e4ec89bcd777021c2eaa756c40
Diff: https://reviews.apache.org/r/25197/diff/
Testing
-------
Added test cases to the new updated privileges.
Thanks,
Sravya Tirukkovalur
