----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25278/#review52481 -----------------------------------------------------------
Ship it! Looks fine to me. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/25278/#comment91281> So we are flattening this into a single set, which I guess is fine. Looks like the map is not need anymore. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/25278/#comment91287> Cool. This fixes a bug in this code :) sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java <https://reviews.apache.org/r/25278/#comment91275> Nit: Doesn't need a new local varialble admin - Prasad Mujumdar On Sept. 2, 2014, 11:30 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25278/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2014, 11:30 p.m.) > > > Review request for sentry and Prasad Mujumdar. > > > Bugs: SENTRY-318 > https://issues.apache.org/jira/browse/SENTRY-318 > > > Repository: sentry > > > Description > ------- > > Allow all users "Show GRANT" as long as they have the grant on that role. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 33600e94bb356ad1095786dacfb4d4f8eb38e8d7 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > f227a027303bac79414f0d12c1f6ce769a5a0ae0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > 8b83859465b748121efa708b9969aeca63b9cbb9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbSentryOnFailureHookLoading.java > 7ffe53420eab315d521de41459ea2cd6ec161dfd > > Diff: https://reviews.apache.org/r/25278/diff/ > > > Testing > ------- > > Added new tests. > > > Thanks, > > Sravya Tirukkovalur > >
