----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25174/#review52604 -----------------------------------------------------------
Ship it! Thanks for the patch Prasad! LGTM. - Sravya Tirukkovalur On Aug. 28, 2014, 11:31 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25174/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 11:31 p.m.) > > > Review request for sentry, Brock Noland and Sravya Tirukkovalur. > > > Bugs: SENTRY-412 > https://issues.apache.org/jira/browse/SENTRY-412 > > > Repository: sentry > > > Description > ------- > > Add infrastructure to capture and print build information. Pretty much the > same way done for other hadoop projects by generating java file during > compile that is annotated with build details. > > > Diffs > ----- > > .gitignore 6a39d39 > sentry-core/sentry-core-common/pom.xml e12469a > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryMain.java > 497c8a4 > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryVersionAnnotation.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryVersionInfo.java > PRE-CREATION > sentry-core/sentry-core-common/src/scripts/saveVersion.sh PRE-CREATION > > Diff: https://reviews.apache.org/r/25174/diff/ > > > Testing > ------- > > Manually verified sentry --version and sentry -v output: > $ bin/sentry --version > Apache Sentry 1.5.0-incubating-SNAPSHOT ,built from > commit#08f05c94d8f7cbf91192e42ed9bf7c6902c3780d ,compiled by prasadm with > source checksum d5e8cef760fdf43b6705f4a6849e4750 > $ bin/sentry -v > Apache Sentry 1.5.0-incubating-SNAPSHOT ,built from > commit#08f05c94d8f7cbf91192e42ed9bf7c6902c3780d ,compiled by prasadm with > source checksum d5e8cef760fdf43b6705f4a6849e4750 > > > Thanks, > > Prasad Mujumdar > >
