----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25137/#review52605 -----------------------------------------------------------
Ship it! - Sravya Tirukkovalur On Aug. 28, 2014, 3:11 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25137/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2014, 3:11 a.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-407 > https://issues.apache.org/jira/browse/SENTRY-407 > > > Repository: sentry > > > Description > ------- > > - Add the old 1.4 init scripts and rename the current ones to 1.5 > - Add upgrade scripts for changes done in SENTRY-339 and SENTRY-327 > - DB upgrade script are inline since it doesn't support nested scripts. > - Handle update sql file names in the schema tool > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreSchemaInfo.java > d6f8cad > > sentry-provider/sentry-provider-db/src/main/resources/001-SENTRY-327.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/001-SENTRY-327.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/001-SENTRY-327.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/001-SENTRY-327.postgres.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.derby.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.mysql.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.oracle.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.postgres.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql > c1a2778 > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql > c1a2778 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql > d7ce57c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql > 3f01cda > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql > 186c968 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-db2-1.4.0-to-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-derby-1.4.0-to-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-mysql-1.4.0-to-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-oracle-1.4.0-to-1.5.0.sql > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry-upgrade-postgres-1.4.0-to-1.5.0.sql > PRE-CREATION > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.db2 > e69de29 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.derby > e69de29 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.mysql > e69de29 > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.oracle > e69de29 > > sentry-provider/sentry-provider-db/src/main/resources/upgrade.order.postgres > e69de29 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentrySchemaTool.java > 38a2e01 > > Diff: https://reviews.apache.org/r/25137/diff/ > > > Testing > ------- > > - Added new test case for upgrade > - Manually tested the tool with MySQL > > > Thanks, > > Prasad Mujumdar > >
