----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24960/#review52641 -----------------------------------------------------------
Ship it! The patch itself looks fine to me. We need to add schema upgrade scripts for migrating older release sentry store schema to this new format. SENTRY-407 which adds the base scripts and framework for handling the schema upgrade. Please file a followup ticket to add the upgrade after SENTRY-407 is committed. - Prasad Mujumdar On Aug. 22, 2014, 5:31 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24960/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2014, 5:31 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Add a filed "column" to privilege > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > 5328fff > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > b39cb18 > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql > c1a2778 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql > c1a2778 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql > d7ce57c > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql > 3f01cda > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql > 186c968 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreToAuthorizable.java > d77786a > > Diff: https://reviews.apache.org/r/24960/diff/ > > > Testing > ------- > > > Thanks, > > Xiaomeng Huang > >
