----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24963/#review53269 -----------------------------------------------------------
Couple of high level comments: - I am wondering if we should support creating view with column level permissions. Today it requres select at table level. If I have access to a subset of columns and create privilege on the database, this feature should also allow me to create a view with that subset of columns. Let me know what you think. - We should more end to end tests for column select access paths, + INSERT OVERWRITE into Table or Directory + CREATE and query views (with the current privilege model) + CREATE TABLE AS query - sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java <https://reviews.apache.org/r/24963/#comment92851> Is it possible to have something other than table or partition ? Should we raise an error in the default case ? - Prasad Mujumdar On Sept. 9, 2014, 11:49 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24963/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2014, 11:49 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Authorization for column level security. This patch is depends on > HIVE-7730(https://reviews.apache.org/r/24962/) > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > a760516 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > 2f97e30 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindings.java > 6e40a5c > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/ResourceAuthorizationProvider.java > 51d4248 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestColumnEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 4c66ffe > > Diff: https://reviews.apache.org/r/24963/diff/ > > > Testing > ------- > > test cases are included. > > > Thanks, > > Xiaomeng Huang > >
