----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25377/#review53761 -----------------------------------------------------------
Ship it! LGTM. One minor comment: I think we should also add test cases where our roleset/ groups are a subset of available ones. So that we can actually make sure they are being filtered out? Please feel free to file a follow on jira if you agree. Thanks! - Sravya Tirukkovalur On Sept. 12, 2014, 4:22 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25377/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2014, 4:22 a.m.) > > > Review request for sentry, Arun Suresh and Sravya Tirukkovalur. > > > Bugs: SENTRY-359 > https://issues.apache.org/jira/browse/SENTRY-359 > > > Repository: sentry > > > Description > ------- > > New thirft RPC to fetch all the privileges for the given set of authorizable > objects > Also the grant privileges API retuns the new grant object created. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 718306d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 6252051 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 070c494 > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > b14616b > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > 5244094 > > Diff: https://reviews.apache.org/r/25377/diff/ > > > Testing > ------- > > Added new test cases. > > > Thanks, > > Prasad Mujumdar > >
