-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26011/
-----------------------------------------------------------
(Updated Sept. 25, 2014, 3:17 a.m.)
Review request for sentry, Lenni Kuff and Sravya Tirukkovalur.
Changes
-------
Addressed review feedback
- Fixed case insensitive role comparison, added testcase
- Added comment in the thrif file
- Fixed typos in variable name
Bugs: SENTRY-469
https://issues.apache.org/jira/browse/SENTRY-469
Repository: sentry
Description
-------
list_sentry_privileges_by_authorizable API should support impersonation similar
to other Sentry service RPCs.
- Add requester username as required argument for the API
- Verify the admin status of the requesting user
- Validate that the requesting user is part of groups and the roles it's trying
to access
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java
0668912
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
e3cdfc2
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift
d8357aa
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java
38cb39b
Diff: https://reviews.apache.org/r/26011/diff/
Testing
-------
Added test case to validated various options of the
list_sentry_privileges_by_authorizable() for non-admin user.
Thanks,
Prasad Mujumdar
