> On Sept. 26, 2014, 8:56 p.m., Sravya Tirukkovalur wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java, > > lines 101-109 > > <https://reviews.apache.org/r/26074/diff/2/?file=706167#file706167line101> > > > > Statements repeated 2 times?
Updated. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26074/#review54713 ----------------------------------------------------------- On Sept. 26, 2014, 5:29 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26074/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2014, 5:29 p.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-472 > https://issues.apache.org/jira/browse/SENTRY-472 > > > Repository: sentry > > > Description > ------- > > Hive binding should validate URI privileges on permenant function resource > URI. The patch includes the output URI check so that if the UDF as a resource > URI it will be verified. > The patch depends on HIVE-8266 which enables Hive compiler to capture the URI > information from create function statement. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > f872ea2 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/HiveAuthzPrivilegesMap.java > 2f97e30 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtFunctionScope.java > f1f64e6 > > Diff: https://reviews.apache.org/r/26074/diff/ > > > Testing > ------- > > Added permenant function test cases. The case which needs HIVE-8266 patch is > currently commented out. > > > Thanks, > > Prasad Mujumdar > >
