----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26337/#review55427 -----------------------------------------------------------
Ship it! - Lenni Kuff On Oct. 4, 2014, 2:58 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26337/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2014, 2:58 a.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, and Sravya Tirukkovalur. > > > Bugs: SENTRY-489 > https://issues.apache.org/jira/browse/SENTRY-489 > > > Repository: sentry > > > Description > ------- > > Sentry DB upgrade fails on Oracle > - Add missing 'COLUMN' keyward for alter table drop column > - use " instread of ` for object names as required by oracle syntax > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.oracle.sql > 67e971a > > sentry-provider/sentry-provider-db/src/main/resources/003-SENTRY-380.oracle.sql > e35bb58 > > Diff: https://reviews.apache.org/r/26337/diff/ > > > Testing > ------- > > Upgrade passes on Oracle DB store with the patch. > > > Thanks, > > Prasad Mujumdar > >
