----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25879/#review56323 -----------------------------------------------------------
Ship it! Looks fine to me. - Prasad Mujumdar On Oct. 12, 2014, 12:42 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25879/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2014, 12:42 a.m.) > > > Review request for sentry, Lenni Kuff, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > The Metastore plugin currently enforces Sentry policies for metadata > modifications. This makes it inconsistent with Hive plugin that support > privileges for both metadata read and write. > We should support the policy enforcement for metadata read as well. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/AuthorizingObjectStore.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 4c66ffe > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 45d24f9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetaStoreWithPigHCat.java > 00d0492 > > Diff: https://reviews.apache.org/r/25879/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
