----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27108/#review58154 -----------------------------------------------------------
Ship it! LGTM. Just wanted to confirm the postgres constants are not an issue. sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.5.0.sql <https://reviews.apache.org/r/27108/#comment99078> Do we need to cast the constants to 'character varying' ? - Prasad Mujumdar On Oct. 23, 2014, 8:22 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27108/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2014, 8:22 p.m.) > > > Review request for sentry, Lenni Kuff and Prasad Mujumdar. > > > Bugs: SENTRY-500 > https://issues.apache.org/jira/browse/SENTRY-500 > > > Repository: sentry > > > Description > ------- > > SENTRY-500: 1.4 to 1.5 upgrade needs to handle empty strings with __NULL__ > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.derby.sql > aceac06fd5db31c16e8b72cd908a3ba3ff3f7724 > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.mysql.sql > a786eccdb9e569a5605c8f5d7ece294c23203982 > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.oracle.sql > f64f69041efe97026c1c0f42d8a1c3ccd277965a > > sentry-provider/sentry-provider-db/src/main/resources/002-SENTRY-339.postgres.sql > 2c9867250237019ced849cb05c76c5141379b920 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.5.0.sql > 4c5ae397d223d2722a187591f57b2b339518598a > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.5.0.sql > bc0d0d8bb7f70ac0f7c1d58a60d905f47d7760f6 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.5.0.sql > 5d8336c9a3a1a676e9308e3672ffa487e9967179 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.5.0.sql > 24cac98f6ae46788e5b82ce4cc3831303897c279 > > Diff: https://reviews.apache.org/r/27108/diff/ > > > Testing > ------- > > Tested it on all dbs(postgres, mysql, oracle and derby). > > > Thanks, > > Sravya Tirukkovalur > >
