> On 十月 21, 2014, 8:24 a.m., Prasad Mujumdar wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java, > > line 107 > > <https://reviews.apache.org/r/25979/diff/1/?file=704005#file704005line107> > > > > It might be good idea to add a private constructor so that it won't be > > instanciated directly in future patches.
Good idea, thank Prasad! - Sun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25979/#review57472 ----------------------------------------------------------- On 十月 9, 2014, 1:48 p.m., Sun Dapeng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25979/ > ----------------------------------------------------------- > > (Updated 十月 9, 2014, 1:48 p.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and > Sravya Tirukkovalur. > > > Bugs: SENTRY-463 > https://issues.apache.org/jira/browse/SENTRY-463 > > > Repository: sentry > > > Description > ------- > > * In **SentryServiceClientFactory** the method **public > SentryPolicyServiceClient create(Configuration conf) throws Exception** can > be static > * Make all **SentryPolicyServiceClient** are called from > **SentryServiceClientFactory** > * Change **SentryPolicyServiceClient** to a interface, > **SentryPolicyServiceClientDefaultImpl** is default implementation > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > 4126341 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java > 2b978d5 > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > 38bf8b2 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java > b66037a > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 0668912 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java > 11545a5 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > 38cb39b > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > cc12099 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > f251ebc > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java > a67556b > > Diff: https://reviews.apache.org/r/25979/diff/ > > > Testing > ------- > > All unitTest passed in local environment. > > > Thanks, > > Sun Dapeng > >
