----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27425/#review59449 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java <https://reviews.apache.org/r/27425/#comment100728> Add comment on whether this it is okay to call stop multiple times. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java <https://reviews.apache.org/r/27425/#comment100727> should this be an || ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java <https://reviews.apache.org/r/27425/#comment100731> nit: single line sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java <https://reviews.apache.org/r/27425/#comment100729> nit: single line - Lenni Kuff On Nov. 1, 2014, 1:01 a.m., Sun Dapeng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27425/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2014, 1:01 a.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and > Sravya Tirukkovalur. > > > Bugs: SENTRY-513 > https://issues.apache.org/jira/browse/SENTRY-513 > > > Repository: sentry > > > Description > ------- > > ````java > public synchronized void stop() throws Exception{ > if (status == Status.NOT_STARTED) { > return; > } > LOGGER.info("Attempting to stop..."); > > if (thriftServer.isServing()) { > thriftServer.stop(); // XXX If got exception here, the code after it > will never be executed. > } > thriftServer = null; > stopSentryWebServer(); > status = Status.NOT_STARTED; > LOGGER.info("Stopped..."); > } > ```` > > if {{thriftServer}} got an exception when do stop, the method > {{stopSentryWebServer()}} will be passed > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java > 0243c48 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > ec17480 > > Diff: https://reviews.apache.org/r/27425/diff/ > > > Testing > ------- > > All Unit Tests passed in my jenkins. > > > Thanks, > > Sun Dapeng > >
