----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27512/#review59578 -----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java <https://reviews.apache.org/r/27512/#comment100854> nit: var name shouldn't be call caps since it's not constant. Also add a comment on what this is mapping (what is the expected key and the expected value). sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java <https://reviews.apache.org/r/27512/#comment100858> The name of this method is not correct because now you are passing a "isLocal" flag so it's not always a DFS. It also seems like the existing Hadoop "Path" class implements all this functionality already. Why can't we use that? sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java <https://reviews.apache.org/r/27512/#comment100857> Curious, where is the IllegalStateException coming from? Seems like this should be an IllegalArgumentException. - Lenni Kuff On Nov. 3, 2014, 8:33 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27512/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2014, 8:33 a.m.) > > > Review request for sentry and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Currently the URI privilege validation assumes that the filesystem prefixes > can be 'file:' or 'hdfs:'. We should make this more generic to support other > prefixes available in the underlying filesystem. > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/PathUtils.java > 1cdbdb8 > > sentry-core/sentry-core-common/src/test/java/org/apache/sentry/core/common/utils/TestPathUtils.java > d30305b > > Diff: https://reviews.apache.org/r/27512/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
