----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24971/#review60695 -----------------------------------------------------------
Ship it! Looks fine to me. Thanks for adding the test cases. Just one comment below. Feel free to log a followup ticket if that needs a code change. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestConfigTool.java <https://reviews.apache.org/r/24971/#comment102076> Is the column name changed to lowercase for file based policies ? Hive column names are case insensitive. - Prasad Mujumdar On Oct. 29, 2014, 7:42 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24971/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2014, 7:42 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > * ConfigImportTool (SentryConfigTool) for column level privilege support > * PolicyFile (SentryPolicyProviderForDb and DBModelAuthorizables) for column > level privilege support > * Enriched or added 10 more testcases in e2e for column level privilege > support > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/authz/SentryConfigTool.java > 2b978d5 > > sentry-policy/sentry-policy-db/src/main/java/org/apache/sentry/policy/db/DBModelAuthorizables.java > 873f789 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtColumnScope.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > f251ebc > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestConfigTool.java > c186a42 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java > eaf3816 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPolicyImport.java > a67556b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/SentryPolicyProviderForDb.java > f98394a > > Diff: https://reviews.apache.org/r/24971/diff/ > > > Testing > ------- > > unit tests in local > > > Thanks, > > Dapeng Sun > >
