> On 十一月 11, 2014, 3:43 p.m., Prasad Mujumdar wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java, > > line 84 > > <https://reviews.apache.org/r/25983/diff/2/?file=733850#file733850line84> > > > > Nit: Is it possible to avoid hardcoding these properties ? > > Dapeng Sun wrote: > It's okay, I removed the property, it is easy to be set by other way.
Hi Prasad, it is a property on server side, remove the property is okay in my local environment. - Dapeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25983/#review60764 ----------------------------------------------------------- On 十一月 12, 2014, 8:16 p.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25983/ > ----------------------------------------------------------- > > (Updated 十一月 12, 2014, 8:16 p.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and > Sravya Tirukkovalur. > > > Bugs: SENTRY-459 > https://issues.apache.org/jira/browse/SENTRY-459 > > > Repository: sentry > > > Description > ------- > > Support Kerberos for SENTRY high availability. In security mode, Zookeeper > will use Kerberos for authentication, SENTRY should use the **principal** and > **keytab** in sentry configuration for authentication > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HAClientInvocationHandler.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/JaasConfiguration.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > bc86963 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerForHaWithoutKerberos.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceForHAWithKerberos.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > cc12099 > > Diff: https://reviews.apache.org/r/25983/diff/ > > > Testing > ------- > > All Unit tests passed in local > > > Thanks, > > Dapeng Sun > >
