----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28456/#review63080 -----------------------------------------------------------
change looks good, but I think you might need to update some of the tests in TestUpdateableAuthzPaths sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestUpdateableAuthzPaths.java <https://reviews.apache.org/r/28456/#comment105249> It looks like lots of the tests here pass a path on the local file system. Won't all these return null now? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java <https://reviews.apache.org/r/28456/#comment105250> grammar - Lenni Kuff On Nov. 25, 2014, 11:52 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28456/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 11:52 p.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > In HDFS sentry plugin we strip off the file system/schema/authority and just > retain the file path assuming it is on HDFS. But right now we are still > adding the non HDFS file path updates as well to the table - path updates. We > need to escape these updates in Hive meta store sentry plugin. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/PathsUpdate.java > 60f8629c11a6ccea85861db639bd6c7e4b218e29 > > sentry-hdfs/sentry-hdfs-common/src/test/java/org/apache/sentry/hdfs/TestUpdateableAuthzPaths.java > 80b765a1b5299ee8b0982a3787c4b619fe2b8a69 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java > 9a81e3a92835f7493fd8abca2a764d5fb2a46c06 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 30c72eb014684c9cad7ecf0e00dacb50c256e579 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestOperations.java > bff372baff0a038840f3480cb0b2d8e062650329 > > Diff: https://reviews.apache.org/r/28456/diff/ > > > Testing > ------- > > Added new test cases. > > > Thanks, > > Sravya Tirukkovalur > >
