----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28507/ -----------------------------------------------------------
Review request for sentry. Repository: sentry Description ------- A revoke on a parent authorizeable was not taking into account the privilege action when removing child privileges. This mean that a REVOKE SELECT ON DATABASE would also delete privileges with an action of ALL or INSERT on child tables/columns. This fix is to verify that each of the child privileges collected "implies" the parent privilege. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java 073bb33 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java e8be81f sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java 3189955 Diff: https://reviews.apache.org/r/28507/diff/ Testing ------- Added new tests. Thanks, Lenni Kuff
