----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25808/#review65066 -----------------------------------------------------------
Ship it! Thank you for working on this guoquan.. The patch looks good.. - Arun Suresh On Dec. 5, 2014, 1:10 p.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25808/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 1:10 p.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Currently the metadata infrastructure in Sentry only supports database > structure authorize model such as Hive/Impala.In order to support other > no-database structure component like Solr, it needs to extend the metadata > infrastructure. Considering the compatibility and not affect the previous > functionality, it is better to add a new privilege in metadata rather than > modifying the original privilege. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryGMPrivilege.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryRole.java > bca9fb9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 594201f > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryGMPrivilege.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestSentryRole.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25808/diff/ > > > Testing > ------- > > > Thanks, > > shen guoquan > >
