----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29041/ -----------------------------------------------------------
Review request for sentry, bc Wong, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur. Repository: sentry Description ------- This patch includes a base SentryStore Decorator (LockingSentryStore) that adds locking to an existing SentryStore It also inclues two implementations for the Decorator 1) SentryStoreWithLocalLock uses the standard java.util.concurrent.ReadWriteLock.. usefull for single instance deployments of the Sentry Service 2) SentryStoreWithDistributedLock implements a Distributed Lock. It uses the Hazelcast (http://hazelcast.org) library. More decription on the JIRA : issues.apache.org/jira/browse/SENTRY-567 TODO: Another possible implementation using Zookeeper. HazelCast and Zookeeper has its own merits. Zookeeper might be better for global lock consistency since it denies availability to peers that are not part of the Quorum in the case of partition tolerence. Hazelcast chooses availibliity but APIs are simpler than Zookeeper. Diffs ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/LockingSentryStore.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreWithDistributedLock.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStoreWithLocalLock.java PRE-CREATION Diff: https://reviews.apache.org/r/29041/diff/ Testing ------- Thanks, Arun Suresh
