----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29393/#review67334 -----------------------------------------------------------
This change looks fine to me, assuming the 90s startup time is unrelated. Let me know and I will +1 it. - Lenni Kuff On Dec. 24, 2014, 8:55 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29393/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2014, 8:55 a.m.) > > > Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, shen > guoquan, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur. > > > Bugs: SENTRY-599 > https://issues.apache.org/jira/browse/SENTRY-599 > > > Repository: sentry > > > Description > ------- > > The patch is fixing a issue that, when sentry service is restarting using > same configuration and context. ** server.isRunning()** will report incorrect > status. > The root cause is **finally** may run after **future = > serviceExecutor.submit(this);**, the status will be **NOT_STARTED** even the > thrift server is started > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 6d96565 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > 4a6cac9 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > be14afd > > Diff: https://reviews.apache.org/r/29393/diff/ > > > Testing > ------- > > Unit Tests passed in apache jenkins > > > Thanks, > > Dapeng Sun > >
