> On 一月 15, 2015, 4:43 p.m., shen guoquan wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java, > > line 99 > > <https://reviews.apache.org/r/29921/diff/1/?file=822479#file822479line99> > > > > you get the allowGroups from the configuration here, why not directly > > transfer the allowGropus to SentryAuthFilter class?
Hi Guoquan, thank you for your review, I tried before but it seems we can only use "filterHolder.setInitParameters(Map<String,String> map)" to pass the parameters. If you have any other idea, please let me know. - Dapeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29921/#review68221 ----------------------------------------------------------- On 一月 15, 2015, 4:09 p.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29921/ > ----------------------------------------------------------- > > (Updated 一月 15, 2015, 4:09 p.m.) > > > Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, shen > guoquan, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur. > > > Bugs: SENTRY-608 > https://issues.apache.org/jira/browse/SENTRY-608 > > > Repository: sentry > > > Description > ------- > > Add **allow.connect.groups** to conf, and using **GroupMappingService** get > user's groups, only user in allow groups can pass. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryAuthFilter.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java > 090917c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 47794bc > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > 0bdc3a2 > > Diff: https://reviews.apache.org/r/29921/diff/ > > > Testing > ------- > > Unit Tests in local > > > Thanks, > > Dapeng Sun > >
