> On Jan. 14, 2015, 6:04 p.m., Lenni Kuff wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java, > > line 71 > > <https://reviews.apache.org/r/29879/diff/1/?file=820782#file820782line71> > > > > Note - AuthenticationFilter is marked as @InterfaceAudience.Private and > > @InterfaceStability.Unstable in hadoop-common. This might be okay, but let > > me follow up with the Hadoop team on their recommendation. > > Dapeng Sun wrote: > I'm agree with you, thank you for your communication with Hadoop team.
It would be good to call out that we are using Private/Unstable Hadoop APIs. - Lenni ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29879/#review68057 ----------------------------------------------------------- On Jan. 15, 2015, 9 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29879/ > ----------------------------------------------------------- > > (Updated Jan. 15, 2015, 9 a.m.) > > > Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, shen > guoquan, Lenni Kuff, Prasad Mujumdar, and Sravya Tirukkovalur. > > > Bugs: SENTRY-503 > https://issues.apache.org/jira/browse/SENTRY-503 > > > Repository: sentry > > > Description > ------- > > Integrate **AuthenticationFilter** for authentication > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryWebServer.java > 090917c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java > 6d96565 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 47794bc > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithKerberos.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryWebServerWithoutSecurity.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > 0bdc3a2 > > Diff: https://reviews.apache.org/r/29879/diff/ > > > Testing > ------- > > Unit Tests passed > > > Thanks, > > Dapeng Sun > >
