----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30261/#review69583 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java <https://reviews.apache.org/r/30261/#comment114291> check groups != null is ok, if empty, the loop will be skipped. For this improvment, do we need to add test case like "grant role role1 to group group1, group group2, group group3"? or current test cases covered this already? - Colin Ma On Jan. 26, 2015, 1:41 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30261/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2015, 1:41 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-617 > https://issues.apache.org/jira/browse/SENTRY-617 > > > Repository: sentry > > > Description > ------- > > Now if we execute "grant role role1 to group group1, group group2, group > group3", we will execute 3 thrift call. > Currently we have thrift API to support grant/revoke one role to/from a set > of groups, so we can improve the client call. > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/hadoop/hive/ql/exec/SentryGrantRevokeTask.java > 69e97a6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 962228f > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClientDefaultImpl.java > d21a401 > > Diff: https://reviews.apache.org/r/30261/diff/ > > > Testing > ------- > > > Thanks, > > Xiaomeng Huang > >
