----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29240/#review69970 -----------------------------------------------------------
sentry-binding/sentry-binding-solr/pom.xml <https://reviews.apache.org/r/29240/#comment114820> ? sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrSentryConfigTool.java <https://reviews.apache.org/r/29240/#comment114823> Could these System.out.println be log? sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrSentryConfigTool.java <https://reviews.apache.org/r/29240/#comment114828> the requestorName is solid? So any user can execute this public API even if it is not admin? sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrSentryConfigTool.java <https://reviews.apache.org/r/29240/#comment114825> could you rename a better name for "a" sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrSentryConfigTool.java <https://reviews.apache.org/r/29240/#comment114824> switch.. case? sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrSentryConfigTool.java <https://reviews.apache.org/r/29240/#comment114831> why we need write a KeyValue class? map is not enough? or other java container? sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrSentryConfigTool.java <https://reviews.apache.org/r/29240/#comment114822> Could this be BeforeClass? so that we will cutdown test time if there are many test cases. - Xiaomeng Huang On 一月 12, 2015, 9:12 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29240/ > ----------------------------------------------------------- > > (Updated 一月 12, 2015, 9:12 a.m.) > > > Review request for sentry, Gregory Chanan and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Currently Solr does support index-level security via sentry with file as > backend privilege store. Using file as the backend store is simple, but there > has some disadvantages as followings: > > Can't satisfied with the needs of dynamically add, delete and update > permissions > Can't be centrally managed and difficult to maintain > According to the above disadvantages, The Solr Sentry plug-in integration > with DB store is demanded. The Hive Sentry plug-in has already integration > with DB store, but the Hive authorization model is different from the Solr > authorization model.So this new feature depends on the generic authorization > model(SENTRY-398) > > > Diffs > ----- > > sentry-binding/sentry-binding-solr/pom.xml 2dfc933 > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrSentryConfigTool.java > PRE-CREATION > > sentry-binding/sentry-binding-solr/src/test/java/org/apache/sentry/binding/solr/TestSolrSentryConfigTool.java > PRE-CREATION > > sentry-binding/sentry-binding-solr/src/test/resources/solr_config_import_tool.ini > PRE-CREATION > > Diff: https://reviews.apache.org/r/29240/diff/ > > > Testing > ------- > > > Thanks, > > shen guoquan > >
