----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30068/#review71541 -----------------------------------------------------------
Ship it! sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java <https://reviews.apache.org/r/30068/#comment118225> Can you expand on exactly what "sync" means? Maybe rename to "isSyncEnabled"? sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java <https://reviews.apache.org/r/30068/#comment118232> Add a comment on which user this is expected to be sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java <https://reviews.apache.org/r/30068/#comment118231> Maybe get rid of "isSync" and just return: providerBackend instanceof SearchProviderBackend; ? sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java <https://reviews.apache.org/r/30068/#comment118229> Are you sure that the only time you make it to this block is when the connection could not be obtained? sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureRequestHandlerUtil.java <https://reviews.apache.org/r/30068/#comment118230> Maybe I am missing something, but I don't see any code to handle the "rename" case. - Lenni Kuff On Jan. 30, 2015, 5:40 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30068/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2015, 5:40 a.m.) > > > Review request for sentry, Xiaomeng Huang, Colin Ma, Dapeng Sun, Gregory > Chanan, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Solr needs to sync collection privileges with Sentry when the metadata has > changed. For example, when the collection has been deleted, the privileges > related to the collection were needed to drop > > > Diffs > ----- > > > sentry-binding/sentry-binding-solr/src/main/java/org/apache/sentry/binding/solr/authz/SolrAuthzBinding.java > faf862f > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/SecureRequestHandlerUtil.java > 8b46388 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/handler/admin/SecureCollectionsHandler.java > 20d9626 > > sentry-solr/solr-sentry-handlers/src/main/java/org/apache/solr/sentry/SentryIndexAuthorizationSingleton.java > d44b228 > > sentry-tests/sentry-tests-solr/src/test/java/org/apache/sentry/tests/e2e/solr/db/integration/TestSolrAdminOperations.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/30068/diff/ > > > Testing > ------- > > All tests have passed through the local jenkins environment > > > Thanks, > > shen guoquan > >
