> On Feb. 13, 2015, 7:25 a.m., Xiaomeng Huang wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java, > > line 36 > > <https://reviews.apache.org/r/30966/diff/1/?file=862915#file862915line36> > > > > could you put setupAdmin into prepareDBDataForTest?
thanks for the comments, done. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30966/#review72338 ----------------------------------------------------------- On Feb. 13, 2015, 7:45 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30966/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2015, 7:45 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Improve test cases in "TestPrivilegesAtTableScope" > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegesAtTableScope.java > 7c861d3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtTableScope.java > 0c15389 > > Diff: https://reviews.apache.org/r/30966/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
