----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31448/#review74167 -----------------------------------------------------------
Ship it! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HAClientInvocationHandler.java <https://reviews.apache.org/r/31448/#comment120694> available Perhaps expand this error message to something more actionable: No Sentry server available. Please verify at least one Sentry server is online and retry the operation. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java <https://reviews.apache.org/r/31448/#comment120695> Comment on what these config options are used for. - Lenni Kuff On Feb. 25, 2015, 11:40 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31448/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 11:40 p.m.) > > > Review request for sentry, Dapeng Sun and Lenni Kuff. > > > Bugs: SENTRY-660 > https://issues.apache.org/jira/browse/SENTRY-660 > > > Repository: sentry > > > Description > ------- > > - Use new config property for principal/keytab settings for secure connection > to ZK. Currently we are using Sentry server principal and keytab which won't > be available on clients like Hive. > - Use the full znode path in preparing ZK ACLs > - Improved error handling > + The Sentry policy client's close() method doesn't throw exception. Hence > add a check in HA proxy handler to supress exception for close(). > + Propogate the exceptions correct back to the caller > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/SentryUserException.java > 9e49a74 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > ed4da96 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HAClientInvocationHandler.java > 52be099 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 8ef586e > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > a8da078 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/ha/TestHaEnd2End.java > 78894d1 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java > 69743bc > > Diff: https://reviews.apache.org/r/31448/diff/ > > > Testing > ------- > > Minor updates to existing tests > HA related tests pass with the patch > > > Thanks, > > Prasad Mujumdar > >
