> On 三月 21, 2015, 4:58 p.m., Prasad Mujumdar wrote: > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java, > > line 28 > > <https://reviews.apache.org/r/31617/diff/2/?file=898537#file898537line28> > > > > I think we should add a warning that db provider is the preferred > > option over file.
Ok, I will add a warning - shen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31617/#review77334 ----------------------------------------------------------- On 三月 18, 2015, 2:02 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31617/ > ----------------------------------------------------------- > > (Updated 三月 18, 2015, 2:02 a.m.) > > > Review request for sentry, Sqoop, Abraham Elmahrek, Xiaomeng Huang, Colin Ma, > Dapeng Sun, and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Add Sqoop policy engine in Sentry for Sqoop role-based authorizaiton > > > Diffs > ----- > > pom.xml 4c80916 > sentry-dist/pom.xml f63b33b > sentry-policy/pom.xml 4fb4f3c > sentry-policy/sentry-policy-sqoop/pom.xml PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/ServerNameRequiredMatch.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SimpleSqoopPolicyEngine.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopModelAuthorizables.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/main/java/org/apache/sentry/policy/sqoop/SqoopWildcardPrivilege.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/AbstractTestSqoopPolicyEngine.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/SqoopPolicyFileProviderBackend.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestServerNameRequiredMatch.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderGeneralCases.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopAuthorizationProviderSpecialCases.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopModelAuthorizables.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineDFS.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopPolicyEngineLocalFS.java > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/java/org/apache/sentry/policy/sqoop/TestSqoopWildcardPrivilege.java > PRE-CREATION > sentry-policy/sentry-policy-sqoop/src/test/resources/log4j.properties > PRE-CREATION > > sentry-policy/sentry-policy-sqoop/src/test/resources/test-authz-provider.ini > PRE-CREATION > > Diff: https://reviews.apache.org/r/31617/diff/ > > > Testing > ------- > > Ran the unit tests. > > > Thanks, > > shen guoquan > >
