----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33134/#review79906 -----------------------------------------------------------
Nice work! Looks mostly fine. A couple of possible concurrency related comments below. sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java <https://reviews.apache.org/r/33134/#comment129500> I guess addToAddPaths() needs to be made thread safe ? sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java <https://reviews.apache.org/r/33134/#comment129501> Result list itself is being changed from the dbTask. Should it be a thread safe queue that's polled for remaining tasks ? sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java <https://reviews.apache.org/r/33134/#comment129502> The finally block is always setting syncSent to true. Should it be unset in this case ? sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java <https://reviews.apache.org/r/33134/#comment129503> Perhaps print a warning that the HDFS ACLs won't be in sync till the sync is completed ? - Prasad Mujumdar On April 13, 2015, 4:10 p.m., Arun Suresh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33134/ > ----------------------------------------------------------- > > (Updated April 13, 2015, 4:10 p.m.) > > > Review request for sentry, Lenni Kuff, Prasad Mujumdar, and Yibing Shi. > > > Repository: sentry > > > Description > ------- > > SENTRY-696 : Improve MetastorePlugin cache initialization latency > > This path introduces the following changes : > 1) Exposes a config variable to allow cache initialization to happen > asynchronously (by default false) > 2) The Cache initialization itself will now be performed in parallel > - It introduces a separate thread pool and attempts to extract > DB/Table/Partition information as separate threadpool tasks > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-common/src/main/java/org/apache/sentry/hdfs/ServiceConstants.java > 489d165 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastoreCacheInitializer.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePlugin.java > 7106e74 > > sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/MetastorePluginWithHA.java > ee5e0f9 > > Diff: https://reviews.apache.org/r/33134/diff/ > > > Testing > ------- > > > Thanks, > > Arun Suresh > >
