----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30363/#review80919 -----------------------------------------------------------
Ship it! Please log the tickets for follow item discussed in the review. - Prasad Mujumdar On April 1, 2015, 12:05 p.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30363/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 12:05 p.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-296 > https://issues.apache.org/jira/browse/SENTRY-296 > > > Repository: sentry > > > Description > ------- > > Since the change in **SENTRY-600 Refactor sentry client factory for "high > availability" and "connection pool"** is too complicated, I refactor this > part, this review request also merge **SENTRY-601 Create connection pool > factory** > > I think this patch might minimized the code change > * Kept the method **public static SentryPolicyServiceClient > create(Configuration conf) throws Exception** > * Add **Generic Type** support to HAClientInvocationHandler and > PoolClientInvocationHandler, it will make integration with other client more > easily > * Put **Connection pool instance** into PoolInvocationHandler, it will make > Client connection can be pooled. > > > Diffs > ----- > > pom.xml cd594b5 > sentry-provider/sentry-provider-db/pom.xml 27ad670 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HAClientInvocationHandler.java > 4947ad1 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/PoolClientInvocationHandler.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryClientInvocationHandler.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientFactory.java > 574f23c > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryServiceClientPoolFactory.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > c8f7450 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerForPoolHAWithoutKerberos.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServerForPoolWithoutKerberos.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceClientPool.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceForPoolHAWithKerberos.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceForPoolWithKerberos.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/SentryServiceIntegrationBase.java > 9a6f8c4 > > Diff: https://reviews.apache.org/r/30363/diff/ > > > Testing > ------- > > Unit Tests passed > > > Thanks, > > Dapeng Sun > >
