----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33469/#review82851 -----------------------------------------------------------
A few minor comments below. Also HDFS e2e tests are disabled in sentry-tests/sentry-tests-hive/pom.xml. We should enable those back as part of this patch. sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java <https://reviews.apache.org/r/33469/#comment133688> Do we really need to import everything from namenode package ? sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java <https://reviews.apache.org/r/33469/#comment133694> Should this permission check be done for non-managed path regardless of caller being a sentry super user ? - Prasad Mujumdar On April 23, 2015, 8:31 a.m., Arun Suresh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33469/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 8:31 a.m.) > > > Review request for sentry, Lenni Kuff and Prasad Mujumdar. > > > Repository: sentry > > > Description > ------- > > Refactor Sentry HDFS Namenode Plugin to use HDFS INodeAttributesProvider : > > * Sentry HDFS namenode plugin uses a pre-committed version of the HDFS > AuthorizationProvider interface. HADOOP 2.7.0 will ship with the new > INodeAttributesProvider interface. > The Namenode plugin has to be refactored to use this new interface. > * The Patch also bumps up the curator version to 2.7.0 to allow all tests to > run. > > > Diffs > ----- > > pom.xml 863f70c > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/hadoop/hdfs/server/namenode/AuthorizationProvider.java > db3d413 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryAuthorizationProvider.java > f3d8aac > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryINodeAttributesProvider.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/MockSentryAuthorizationProvider.java > 2085b52 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/MockSentryINodeAttributesProvider.java > PRE-CREATION > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryAuthorizationProvider.java > 40b803e > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/test/java/org/apache/sentry/hdfs/TestSentryINodeAttributesProvider.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegration.java > 8ddfbe7 > > Diff: https://reviews.apache.org/r/33469/diff/ > > > Testing > ------- > > > Thanks, > > Arun Suresh > >
